Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(taps,targets): Support the singer.decimal JSON Schema extension #2786

Draft
wants to merge 2 commits into
base: edgarrmondragon/refactor/jsonschematosql-fromconfig
Choose a base branch
from
Draft

feat(taps,targets): Support the singer.decimal JSON Schema extension #2786

wants to merge 2 commits into from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 30, 2024 •
edited by github-actions bot
Loading

TODO:

  • Docs
  • Capability/Built-in setting

Related:

📚 Documentation preview 📚: https://meltano-sdk--2786.org.readthedocs.build/en/2786/

@edgarrmondragon edgarrmondragon added SQL Support for SQL taps and targets Type/Target Singer targets Type/Tap Singer taps labels Nov 30, 2024
@edgarrmondragon edgarrmondragon self-assigned this Nov 30, 2024
@edgarrmondragon edgarrmondragon mentioned this pull request Nov 30, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base (de53f85) to head (ff67a40).

Files with missing lines Patch % Lines
singer_sdk/connectors/sql.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@                                   Coverage Diff                                   @@
##           edgarrmondragon/refactor/jsonschematosql-fromconfig    #2786      +/-   ##
=======================================================================================
- Coverage                                                91.03%   90.89%   -0.15%     
=======================================================================================
  Files                                                       62       62              
  Lines                                                     5174     5182       +8     
  Branches                                                   666      667       +1     
=======================================================================================
  Hits                                                      4710     4710              
- Misses                                                     326      333       +7     
- Partials                                                   138      139       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #2786 will not alter performance

Comparing edgarrmondragon/feat/singer-decimal (ff67a40) with edgarrmondragon/refactor/jsonschematosql-fromconfig (de53f85)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/jsonschematosql-fromconfig branch from de53f85 to 42a702d Compare November 30, 2024 20:27
@s7clarke10
Copy link
Contributor

That's awesome, thanks once again @edgarrmondragon 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edgarrmondragon edgarrmondragon

Labels
SQL Support for SQL taps and targets Type/Tap Singer taps Type/Target Singer targets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarrmondragon @s7clarke10